Re: [PATCH] Fix 'git clean' failure on NFS.

From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: Jun 18, 2010, 12:29 UTC
Message-ID: <AANLkTimm1XMmDORpnezYHSNPrKFup2H5ODQLrgJivDwg@mail.gmail.com>
In-Reply-To: <1276859235-13534-1-git-send-email-edwintorok@gmail.com>

2010/6/18 Török Edwin <edwintorok@gmail.com>:

Show 8 quoted lines

> readdir() used to do a single pass, which is not always enough.
> If you unlink some files/rmdir some subdirs then there might be some
> files you haven't seen yet *before* the readdir cursor (files get rearranged
> in the directory, etc.).
>
> The fix is to do an additional readdir() pass if we unlinked/rmdired something.
> This is easily accomplished by using rewinddir.
>

Won't this break on Windows? mingw_readdir() doesn't seem to have a maching mingw_rewinddir() in compat/mingw.c/h....

-- 
Erik "kusma" Faye-Lund