Re: patch for git-p4

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Jan 5, 2011, 21:31 UTC
Message-ID: <AANLkTimdMH_HcF-Qk3SSmqT24OgxynYnXpSLiDtU7Y6c@mail.gmail.com>
In-Reply-To: <AANLkTi=sNsDy9oo0iBE-qJwvFSDMFYma3oYhbP1J-th=@mail.gmail.com>

On Wed, Jan 5, 2011 at 2:45 AM, Andrew Garber <andrew@andrewgarber.com> wrote:

> Hi everyone! This is my first post to the git mailing list.
>

Welcome!

Show 8 quoted lines

> I was reading the git-p4 source and noticed that some of the lines are
> indented using tabs instead of spaces (very bad in Python). Here's a
> patch against tag v1.7.4-rc0 (commit
> 01b97a4cb60723d18b437efdc474503d2a9dd384) of the git source repo.
>
> Thanks!
> Andrew Garber
>

Please read Documentation/SubmittingPatches for the correct procedure
for submitting patches. The two most important things is:
1) We send patches inline instead of attached (git send-email can do
this for you)
2) You need to add a sign-off

As a side-note, your commit message has some broken grammar in it. "Some the commits", I'm guessing you omitted a "of" there?

We tend not to write commit messages in past tence. E.g "git-p4: replace tabs with spaces" (notice that I removed a 'd').