Re: [PATCH] Add known breakage for 'git notes copy'

From

Bert Wesarg <bert.wesarg@googlemail.com>

Date

Jun 28, 2010, 09:12 UTC

Message-ID

<AANLkTimap7ziJ-NuAV6h7bGP3cX2cDY7rqEbgJ2unQSP@mail.gmail.com>

In-Reply-To

<20100628085907.GA14014@coredump.intra.peff.net>

On Mon, Jun 28, 2010 at 10:59, Jeff King <peff@peff.net> wrote:

> On Mon, Jun 28, 2010 at 09:01:57AM +0200, Bert Wesarg wrote:
>
>> 'git notes copy' dumps core when no arguments are given.
>
> How about:

Thanks.

Tested-by: Bert Wesarg <Bert.Wesarg@googlemail.com>

FWIW, here is the correct and updated test for this:

-- >8 --
Subject: [PATCH] notes: add test for git-notes copy with too few arguments

Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
---
 t/t3301-notes.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 64f32ad..dcd962a 100755 t/t3301-notes.sh
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -1044,4 +1044,9 @@ test_expect_success 'GIT_NOTES_REWRITE_REF
overrides config' '
 	git log -1 > output &&
 	test_cmp expect output
 '
+
+test_expect_success 'git notes copy does not segfaults with too few
arguments' '
+	test_must_fail git notes copy
+'
+
 test_done