Re: [PATCH v2 3/5] t/t5800-remote-helpers.sh: Skip with prereq on python <2.4

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 29, 2010, 02:03 UTC
Message-ID: <AANLkTimZ5GFMn3p3UxgWrY1sMpguA4PZ0F=oGtT02JJQ@mail.gmail.com>
In-Reply-To: <20100729011602.GG29156@dert.cs.uchicago.edu>

On Thu, Jul 29, 2010 at 01:16, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 21 quoted lines

> Ævar Arnfjörð Bjarmason wrote:
>
>> Change the t/t5800-remote-helpers.sh test to skip with the the
>> three-arg prereq form of test_expect_success instead of bailing out.
>
> Right:
>
>> +++ b/t/t5800-remote-helpers.sh
>> @@ -13,13 +13,11 @@ if sys.hexversion < 0x02040000:
>>      sys.exit(1)
>>  '
>>  then
>> -     :
>> -else
>> -     skip_all='skipping git remote-testgit tests: requires Python 2.4 or newer'
>> -     test_done
>> +    # Requires Python 2.4 or newer
>> +     test_set_prereq PYTHON_24
>>  fi
>
> And as a bonus, this makes the test clearer.  Nice.

Yup, <prereq> is really nice in all regards.

> I would suggest dropping the "Requires Python 2.4" comment, or
> maybe moving it somewhere else with a change to explain that
> it is git-remote-testgit that requires Python ≥ 2.4
> (rather than the remote helper facility in general).

I put it there to make the connection between 24, 0x02040000, and 2.4.

I think trying to avoid confusion like that isn't a problem in a test file, it's pretty obvious from the context that the prereq only has to do with the test. Someone looking up remote helpers is going to do that in the documentation, not in some t/ test file.

Thanks for your continuing & detailed reviews b.t.w.