NO_REGEX defaults on obscure platforms

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 8, 2010, 15:12 UTC
Message-ID: <AANLkTimYY_KHwqWWXTxFqW67FHYtJJkLuA-6WVc6wzO5@mail.gmail.com>

On Mon, Sep 6, 2010 at 07:41, Junio C Hamano <gitster@pobox.com> wrote:

> There are a few leftover bits in 'next' that need to be merged to 'master'
> before we declare a real -rc cycle, so tonight's pushout is -rc0.

One thing that's almost certainly wrong in v1.7.3-rc0 is the NO_REGEX defaults. It's a non-issue for people who run the configure script, but the Makefile probably has the wrong defaults on some obscure platforms.

I've CC'd people involved in Tru64, UnixWare, SCO, HP/UX, IRIX etc. It would be really useful if you could:

  1. Get v1.7.3-rc0
  2. Compile with the defaults, and NO_REGEX=YesPlease
  3. Run `cd t && ./t7008-grep-binary.sh` and report the results.

That test is probably failing on some of these platforms.

Alternatively, just check for REG_STARTEND in regex.h (or the includes it pulls in):

    $ grep REG_STARTEND /usr/include/regex.h
    #define REG_STARTEND (1 << 2)