git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fast-export: ensure that a renamed file is printed after all references

From
Elijah Newren <newren@gmail.com>
Date
Sep 8, 2010, 19:26 UTC
Message-ID
<AANLkTimS96c1YFC+UUw0iRoPVT=COFhDRoSO1cNHYhTf@mail.gmail.com>
In-Reply-To
<201009082047.50083.j6t@kdbg.org>
On Wed, Sep 8, 2010 at 12:47 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 8 quoted lines
> On Mittwoch, 8. September 2010, Elijah Newren wrote:
>> Patch and description looks good to me...however, I was a little
>> surprised to see no testsuite addition or additional explanation.  Are
>> you seeing some t9350 tests fail on some platform despite passing on
>> linux?
>
> Yes, I see the problem in t9350 on Windows. It is impossible to write a test
> for it because the test would depend on the unspecified behavior of qsort.

Makes sense. Would it be worth briefly mentioning Windows in the commit message?

Either way,
Acked-by: Elijah Newren <newren@gmail.com>
> BTW, I don't know whether the diff machinery guarantees to produce 'C' and 'R'
> records in this order. If there is no such guarantee, then fast-export would
> have been broken even before 060df62.
Previous: Johannes Sixt
Message 4 of 4 in “fast-export: ensure that a renamed file is printed after all references”
  1. fast-export: ensure that a renamed file is printed after all referencesJohannes Sixt, Sep 7, 2010
  2. Elijah NewrenSep 8, 2010
  3. Johannes SixtSep 8, 2010
  4. Elijah NewrenSep 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.