Re: [BUG] git-svn fails to rename files with %20 in filename

From: Steven Scott <steven@codemettle.com>
Date: Mar 2, 2011, 15:27 UTC
Message-ID: <AANLkTimQTwSPnyNBBNnSYLStZqQvBjWk0ydOpcw1UiwO@mail.gmail.com>
In-Reply-To: <20110223100431.GD9222@sigill.intra.peff.net>

On Wed, Feb 23, 2011 at 5:04 AM, Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

>
> On Tue, Feb 22, 2011 at 04:50:15PM +0000, Will Palmer wrote:
>
> > > IOW, it looks like the path we hand to svn needs url-encoding even for
> > > the local case (which make sense, as it is a file:// url). But I know
> > > nothing about svn, so probably I am breaking some other weird non-url
> > > local case. :)
> > >
> >
> > Unless I've got my line-numbers mixed up, the commit which introduced
> > the https-specific encoding behaviour,
> > 29633bb91c git-svn: fix commiting renames over DAV with funky file names
> >
> > seems to be of the opinion that the bug did not effect file:// and
> > svn:// URLs. Has something changed?
>
> Yeah, what we are seeing definitely contradicts that commit. It's been
> 3.5 years; maybe something was tweaked in the subversion library? I
> tried reading the code, but I got lost amidst all of the nasty perl
> bindings. I couldn't find anything relevant in svn's changelog or in
> google, either.
>

In my case, I *was* using http://, and applying that patch (to remove the HTTP check) didn't work. Same error as earlier in the thread. I thought it worked once, but I eventually saw it fail again. git-svn is definitely broken if the URL has a %20 in it, and it's quite useless when you never know when you'll be unable to dcommit and manually have to generate patches and apply them to a svn repository.

Thankfully I got my team to switch to git, so best of luck to the rest of you trying to use git-svn when a doofus put a space in the URL :)

-- Steven Scott