Re: [TopGit PATCH v2] tg-patch: use pretty_tree
- From
Bert Wesarg <bert.wesarg@googlemail.com>
- Date
- Oct 5, 2010, 20:14 UTC
- Message-ID
- <AANLkTimQ6CQonVJRuUzZkzbNFPsHkt4nSD70Fp_Ug1rp@mail.gmail.com>
- In-Reply-To
- <20101005200159.GZ11737@pengutronix.de>
2010/10/5 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
Show 11 quoted lines
> On Tue, Oct 05, 2010 at 09:04:46PM +0200, Bert Wesarg wrote: >> This applies the same treatment to tg-patch like tg-files got in v2. >> >> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com> >> >> --- >> >> Basing the decision whether to use the ui diff or the porcelain diff-tree >> is probably very unorthodox, but also makes sense, doesn't it? > Uuuuuh, I'd feel better with git diff-tree --color=auto. Why did you > decide against that?
Because there are more config options which diff-tree ignores, for example diff.mnemonicprefix or diff.noprefix. While diff.mnemonicprefix unfortunately should not work in our case (git diff can't decide just from the two tree-ishs what is what) but we could provide our own prefixes with --{src,dst}-prefix. See diff.c:git_diff_ui_config() for the full list. I also have a small patch in my git tree which is only recognized by the ui diff.
BTW. I accidentally removed the '(No changes)' case, which I'm working on right now.
Bert