git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] index-pack: Create .keep files with same permissions and .pack/.idx

From
Shawn Pearce <spearce@spearce.org>
Date
Apr 1, 2011, 21:49 UTC
Message-ID
<AANLkTimMJxni=Vuja+iHyMp8ydm7ZBvWnkSe68g6+pyH@mail.gmail.com>
In-Reply-To
<7v1v1lfy7q.fsf@alter.siamese.dyndns.org>
On Fri, Apr 1, 2011 at 17:39, Junio C Hamano <gitster@pobox.com> wrote:
> While I am not sure if letting a clone proceed while there is a concurrent
> push is even a good idea to begin with,
What? Why?

Are you suggesting that Git hosting sites disable readers while there is a push occurring?

We have tried hard to design Git to be concurrent reader/writer safe, *except* the actual garbage collection part of `git gc` that deletes loose objects. There is no reason to prevent concurrent readers while there is a push in progress.

The only problem is a cpio based clone, which may link the objects directory before the refs, and miss linking the new pack but wind up linking the new ref, making the clone corrupt. But that is a bug in the cpio clone implementation. Using file:// to use the classical pipe is safe here, because the refs are scanned before the objects are. IMHO, if you think clone during push is unsafe because of this, we should fix the cpio clone path to do a `git ls-remote` on the source, cache the refs in memory, copy the objects, then write out a packed-refs file containing the refs we snapshotted *before* linking the objects directory into the new clone.

-- 
Shawn.
Previous: Jeff KingNext: Junio C Hamano
Message 6 of 14 in “Problems with stale .keep files on git server”
  1. Johan HerlandMar 31, 2011
  2. Jeff KingMar 31, 2011
  3. 1/2 index-pack: Create .keep files with same permissions and .pack/.idxJohan Herland, Apr 1, 2011
  4. Junio C HamanoApr 1, 2011
  5. Jeff KingApr 1, 2011
  6. Shawn PearceApr 1, 2011
  7. Junio C HamanoApr 1, 2011
  8. Johan HerlandApr 1, 2011
  9. Junio C HamanoApr 2, 2011
  10. Johan HerlandApr 3, 2011
  11. Johan HerlandApr 1, 2011
  12. 2/2 repack: Remove stale .keep files before repackingJohan Herland, Apr 1, 2011
  13. Jeff KingApr 1, 2011
  14. Johan HerlandApr 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.