Re: [PATCH] more portable absolute dir check in Git.pm
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Feb 6, 2011, 22:32 UTC
- Message-ID
- <AANLkTimLCnYYv74NMumXHOdWuNBt3ontLo4v-Ey_0kay@mail.gmail.com>
- In-Reply-To
- <4D4D7890.3020906@io.com>
On Sat, Feb 5, 2011 at 5:19 PM, Rafael Kitover <rkitover@io.com> wrote:
Show 6 quoted lines
> I was trying to get msysGit to work with activeperl. I'm not sure how far I > got, I will revisit this problem in the future, but here is a patch. > > It removes a problematic make fragment that doesn't work on nmake (and > probably dmake as well.) As well as a better absolute dir check in Git.pm . >
Please read Documentation/SubmittingPatches. In particlar: - We use inline patches on the mailing-list. git send-email can send these for you. - Your patch lacks a sign-off.
Other than that, interesting. But I think the make_frag-changes needs an explanation.