git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] en/object-list-with-pathspec (v3?)

From
Elijah Newren <newren@gmail.com>
Date
Sep 8, 2010, 07:47 UTC
Message-ID
<AANLkTimFRUfK2+yNGkgJX8K-0N5QYOp4ud2O7afH_iNz@mail.gmail.com>
In-Reply-To
<1283874483-32017-1-git-send-email-pclouds@gmail.com>
2010/9/7 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
Show 8 quoted lines
> Changes from last time is tree_entry_interesting() now takes
> struct exclude * as the pathspecs.
>
> I think there'll be a bit of performance loss because diff_options.el
> is not initialized from the beginning. But that requires more changes
> outside tree-diff.c (makes sure that diff_options.el is copied properly,
> makes sure that diff_tree_setup_* is called ...) So one step at a time.
> I'm working on it.

Looks reasonable to me so far. I believe your series already makes nr_paths, paths, and pathlens fields from diff_options unused (other than via exclude_list) -- yes? If so, that suggests that we could just modify diff_tree_setup_paths() to do the work that your new diff_tree_setup_exclude_lists() is doing (and to take an exclude_list* instead of a diff_options*). Then you wouldn't need to worry about doing the setup "on-the-fly" and the performance differences should go away.

Am I understanding correctly, and is that the route you're going?
Previous: Nguyễn Thái Ngọc DuyNext: Nguyen Thai Ngoc Duy
Message 7 of 8 in “en/object-list-with-pathspec (v3?)”
  1. 0/5 en/object-list-with-pathspec (v3?)Nguyễn Thái Ngọc Duy, Sep 7, 2010
  2. 1/5 diff-no-index.c: rename read_directory() to read_dir()Nguyễn Thái Ngọc Duy, Sep 7, 2010
  3. 2/5 Add testcases showing how pathspecs are ignored with rev-list --objectsNguyễn Thái Ngọc Duy, Sep 7, 2010
  4. 3/5 tree-walk: move tree_entry_interesting() from tree-diff.cNguyễn Thái Ngọc Duy, Sep 7, 2010
  5. 4/5 tree_entry_interesting(): remove dependency on struct diff_optionsNguyễn Thái Ngọc Duy, Sep 7, 2010
  6. 5/5 Make rev-list --objects work together with pathspecsNguyễn Thái Ngọc Duy, Sep 7, 2010
  7. Elijah NewrenSep 8, 2010
  8. Nguyen Thai Ngoc DuySep 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.