Re: [PATCH 2/2] push: better error messages for detached HEAD and "no destination"

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 28, 2011, 22:48 UTC
Message-ID: <AANLkTim7O4O2UUWzZOrZOWN1zp2iruLYf3+3WMFTi8_5@mail.gmail.com>
In-Reply-To: <1298927645-2716-3-git-send-email-Matthieu.Moy@imag.fr>

On Mon, Feb 28, 2011 at 4:14 PM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:

Show 10 quoted lines

> ---
>  builtin/push.c |   12 ++++++++++--
>  1 files changed, 10 insertions(+), 2 deletions(-)
>
> @@ -152,7 +153,14 @@ static int do_push(const char *repo, int flags)
>        if (!remote) {
>                if (repo)
>                        die("bad repository '%s'", repo);
> -               die("No destination configured to push to.");
> +               die("No destination configured to push to.\n"

The dangling preposition is awkward. How about:

  No configured push destination.

Or

  Push destination not configured.

> +                   "Either specify the URL from the command line or configure a remote repository using\n"

Maybe "Either specify the URL explicitly or configure..."

> +                   "\n"
> +                   "    git remote add <name> <url>\n"
> +                   "\n"
> +                   "and then push using the remote name like\n"

s/like//

> +                   "\n"
> +                   "    git push <name>\n");

Well, I just bikeshedded that 3 different colors, didn't I? You're welcome. :-)

j.