Re: [PATCH] worktree: provide better prefix to go back to original cwd

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Oct 7, 2010, 03:14 UTC
Message-ID: <AANLkTim7=8ALxBKWhYcZRSqAcxi0O-T-pxmYpG8_N8v7@mail.gmail.com>
In-Reply-To: <7v4ocz18az.fsf@alter.siamese.dyndns.org>

On Thu, Oct 7, 2010 at 1:32 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Are there any examples to illustrate whether teaching --show-prefix to
>> do what your --worktree-to-cwd does would be a good or bad idea?
>> (Just curious.)
>
> Do these additions interact well with the notion of "we are in the working
> tree" vs "we are outside the working tree"?  Even when we happen to know
> via GIT_WORK_TREE that the root of the working tree is /var/tmp/junk, we
> should correctly diagnse that we are outside the working tree when we are
> in /var/tmp/, and require_work_tree should say "no you are not allowed to
> do this", no?

It should work as it does now. I don't change prefix calculation and chdir() behavior. So when you're at /var/tmp, require_work_tree should say no.

-- 
Duy