git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] commit-tree: free commit message before exiting

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Oct 2, 2010, 20:12 UTC
Message-ID
<AANLkTim6hA5ShAYWm63vyybyTqRxgKVjv3EFcQ5dZWCW@mail.gmail.com>
In-Reply-To
<20101002182600.GB24523@burratino>
Heya,
On Sat, Oct 2, 2010 at 20:26, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Probably this series should cook outside mainline until the test suite
> runs without reporting any unsuppressed leaks.
That would be very nice :).
Show 6 quoted lines
> I still would be
> interested in more comments on the approach, though.  If KEEP_WRAPPER
> were conditionally defined to be empty (so by default people _would_
> find the tail calls in those sentinel functions eliminated --- i.e.,
> no performance impact unless you ask for it), would that be more
> acceptable?

I suppose developers that are interested can easily turn it on in their config.mak, and I think it's definitely useful to have this available to make sure we don't introduce any new leaks.

The question of course is, is there anyone interested in cleaning up this mess? Do you mean to keep it up and get the test suite to the point where there are no leak warnings?

-- 
Cheers,

Sverre Rabbelier
Previous: Jonathan NiederNext: Jonathan Nieder
Message 28 of 33 in “memory leak reported by valgrind”
  1. memory leak reported by valgrindIvan Kanis, Aug 9, 2010
  2. Junio C HamanoAug 9, 2010
  3. Erik Faye-LundAug 9, 2010
  4. Alex RiesenAug 9, 2010
  5. Jonathan NiederAug 10, 2010
  6. 1/3 core: Stop leaking ondisk_cache_entrysJonathan Nieder, Aug 10, 2010
  7. 2/3 write-tree: Avoid leak when index refers to an invalid objectJonathan Nieder, Aug 10, 2010
  8. 3/3 read-tree: stop leaking tree objectsJonathan Nieder, Aug 10, 2010
  9. 0/7 Re: [PATCH] memory leak reported by valgrindJonathan Nieder, Oct 2, 2010
  10. 1/7 init: plug tiny one-time memory leakJonathan Nieder, Oct 2, 2010
  11. Junio C HamanoOct 3, 2010
  12. init: plug tiny one-time memory leakJonathan Nieder, Oct 4, 2010
  13. 2/7 lockfile: introduce alloc_lock_file() to avoid valgrind noiseJonathan Nieder, Oct 2, 2010
  14. Andreas EricssonOct 2, 2010
  15. Jonathan NiederOct 2, 2010
  16. Junio C HamanoOct 6, 2010
  17. Jonathan NiederOct 6, 2010
  18. Junio C HamanoOct 6, 2010
  19. Jonathan NiederOct 6, 2010
  20. 3/7 environment.c: remove unused variableJonathan Nieder, Oct 2, 2010
  21. 4/7 setup: make sure git dir path is in a permanent bufferJonathan Nieder, Oct 2, 2010
  22. Nguyen Thai Ngoc DuyOct 4, 2010
  23. 5/7 Introduce malloc/strdup/pathdup variants for permanent allocationsJonathan Nieder, Oct 2, 2010
  24. 6/7 environment: use alloc_permanent() for computed git_dir and coJonathan Nieder, Oct 2, 2010
  25. 7/7 commit-tree: free commit message before exitingJonathan Nieder, Oct 2, 2010
  26. Sverre RabbelierOct 2, 2010
  27. Jonathan NiederOct 2, 2010
  28. Sverre RabbelierOct 2, 2010
  29. Jonathan NiederOct 2, 2010
  30. Junio C HamanoOct 4, 2010
  31. Jonathan NiederOct 4, 2010
  32. Junio C HamanoOct 4, 2010
  33. Jonathan NiederOct 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.