Re: [PATCH] builtin/rm.c: Use ALLOC_GROW instead of alloc_nr and xrealloc.
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Dec 19, 2010, 03:02 UTC
- Message-ID
- <AANLkTim4GE0mnCBqz6QubpL6g9Bz5U-jHoOw=_MR5-1j@mail.gmail.com>
- In-Reply-To
- <ffd7b63f3ef5e409775a0d730691efdaf4e41592.1292291262.git.tfransosi@gmail.com>
On Tue, Dec 14, 2010 at 8:48 AM, Thiago Farina <tfransosi@gmail.com> wrote:
Show 9 quoted lines
> static void add_list(const char *name)
> {
> - if (list.nr >= list.alloc) {
> - list.alloc = alloc_nr(list.alloc);
> - list.name = xrealloc(list.name, list.alloc * sizeof(const char *));
> - }
> + ALLOC_GROW(list.name, list.nr + 1, list.alloc);
> list.name[list.nr++] = name;
> }add_list() is only used at one place, why not remove it and put the code back in cmd_rm()?
-- Duy