git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] Dont use the same variable for different things

From
João P. Sampaio <jpmelos@jpmelos.com>
Date
Feb 17, 2011, 02:36 UTC
Message-ID
<AANLkTim3t3JTFh668YK+GtS+iRDZLjnhS7bMUGW1fim+@mail.gmail.com>
In-Reply-To
<7v62sjfna2.fsf@alter.siamese.dyndns.org>
On Wed, Feb 16, 2011 at 23:44, Junio C Hamano <gitster@pobox.com> wrote:
> But more important question is why?
>
> What benefit are we getting by almost doubling the stack footprint of this
> function?  What problem are you fixing?

Well, in matters of code readability and maintainability, it's best to use different variables for different matters...

Nowadays, memory isn't really an issue anymore, is it? I think it's valid to make code more readable, if memory cost isn't absurd.

-- 
João Paulo Melo de Sampaio
Computer Engineering Student @ UFSCar
Website: http://www.jpmelos.com
Twitter: http://twitter.com/jpmelos (@jpmelos)
Previous: Junio C HamanoNext: Vasyl' Vavrychuk
Message 8 of 12 in “clean-up store_updated_refs”
  1. 0/4 clean-up store_updated_refsVasyl' Vavrychuk, Feb 12, 2011
  2. 1/4 Reduce url_len variable scopeVasyl' Vavrychuk, Feb 12, 2011
  3. Junio C HamanoFeb 17, 2011
  4. 2/4 Extract function trim_url and optimize calls of it.Vasyl' Vavrychuk, Feb 12, 2011
  5. Junio C HamanoFeb 17, 2011
  6. 3/4 Dont use the same variable for different thingsVasyl' Vavrychuk, Feb 12, 2011
  7. Junio C HamanoFeb 17, 2011
  8. João P. SampaioFeb 17, 2011
  9. 4/4 Replace pointer arithmetic with strbufVasyl' Vavrychuk, Feb 12, 2011
  10. Sverre RabbelierFeb 13, 2011
  11. Vasyl'Feb 13, 2011
  12. Sverre RabbelierFeb 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.