Re: Cooking of the ab/i18n series

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 6, 2010, 12:33 UTC
Message-ID: <AANLkTim1G=wjAgts_BvjwU8_B1wqrUEQHWbP_MY=cJa9@mail.gmail.com>
In-Reply-To: <7vzkx0bt4w.fsf@alter.siamese.dyndns.org>

On Thu, Aug 5, 2010 at 22:18, Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> On Wed, Aug 4, 2010 at 22:24, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Since we're asking about the status of series...
>>
>>> * tr/ab-i18n-fix (2010-07-25) 1 commit
>>>  - tests: locate i18n lib&data correctly under --valgrind
>>>  (this branch uses ab/i18n.)
>>
>>> * ab/i18n (2010-07-19) 2 commits
>>>  - tests: rename test to work around GNU gettext bug
>>>  - Add infrastructure for translating Git with gettext
>>>  (this branch is used by tr/ab-i18n-fix.)
>>
>> Do you have any plans for when to merge the i18n series?
>
> When people see the benefit of doing so.  I currently do not see much need
> for it myself but I am a minority ;-).

That's news to me. I'd assumed that it was mostly on track, i.e. that it would get merged down after cooking for a while in pu.

However, if it's a matter of gathering popular support maybe I should change my strategy a bit.

Perhaps it would help if I sent the entire series as it is in pu now to the list along with a cover letter explaining the main implications of merging it?

All the RFCs so far have either focused on discussing the idea without the implementation, or small parts of the implementation that needed to be improved.

>> It's been cooking for a while now, and it'll need a lot of follow-up
>> work (gettextizing) once it gets merged.
>
> Yeah, and s/once/before/ probably.

What sort of work do you think is needed before it's merged? It seems to Just Work everywhere I and others have tested it (sans some minor patches like working around old gettext bugs).

The follow-up work I was referring to was the project we'll need to undertake once it's merged to convert "foo" to _("foo") as appropriate.

What sort of work do you think might be needed before it's merged?