Re: [PATCH] Add git format-patch produced patches to .gitignore
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 16, 2010, 13:06 UTC
- Message-ID
- <AANLkTilsZ1Dzsu6GwWaNh8WvMrzpQtj5AQNDavdYuCjf@mail.gmail.com>
- In-Reply-To
- <20100516075244.GA9010@progeny.tock>
On Sun, May 16, 2010 at 07:52, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 19 quoted lines
> Pavan Kumar Sunkara wrote: >> Ævar Arnfjörð Bjarmason wrote: > >>> --- a/.gitignore >>> +++ b/.gitignore >>> @@ -203,3 +203,4 @@ >>> *.pdb >>> /Debug/ >>> /Release/ >>> +[0-9][0-9][0-9][0-9]-*.patch > [...] >> git format-patch -M origin/master -o outgoing/ >> >> So, my patches will be in subdirectory outgoing. >> But the regex rule in this patch won't be able to hide them. >> >> What do u want to do in that case ? > > Try it out.
Right, patches in outgoing/ will be ignored too because the rule isn't prefixed with /, so it works regardless of whether the file is in a subdirectory or not.
> In fact, I was worried that this patch would trigger a similar > problem: maybe some test data directory contains format-patch > output? In fact none do, so I like the patch.
None do, there's no file that matches '????-*.patch' in Git. Even if there was you could still 'git add -f' it, which wouldn't be that big of a problem because it would be part of some rarely touched test suite in t/*.