Explanation for dropping write-back in mmap

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jun 7, 2010, 15:16 UTC
Message-ID: <AANLkTilrinkNo9awJ9Wso4tXzQKghWEd2bfDRhPHPOga@mail.gmail.com>

Hi Junio,

In the commit f48000fcbe100, you've forced the caller to use MAP_PRIVATE in the alternative mmap implementation dropping write-back support. Could you kindly explain the rationale for this? David's SVN exporter uses mmap with MAP_SHARED, and we figured that the merge immediately breaks this functionality.

Noticed-by: Jonathan Nieder <jrnieder@gmail.com>

-----------------------------------------------------------------------------------------------------------
commit f48000fcbe1009c18f1cc46e56cde2cb632071fa
Author: Junio C Hamano <junkio@cox.net>
Date:   Sat Oct 8 15:54:36 2005 -0700

    Yank writing-back support from gitfakemmap.

    We do not write through our use of mmap(), so make sure callers pass
    MAP_PRIVATE and remove support for writing changes back.

    Signed-off-by: Junio C Hamano <junkio@cox.net>
-----------------------------------------------------------------------------------------------------------

Thanks.

-- Ram