git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 1/5] test-lib: Adjust output to be valid TAP format

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 25, 2010, 21:24 UTC
Message-ID
<AANLkTilYoGtTIr9lIQD4sx4PRjlWYjIwSDMquREzv6eq@mail.gmail.com>
In-Reply-To
<7v6317koy2.fsf@alter.siamese.dyndns.org>
On Fri, Jun 25, 2010 at 17:21, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> diff --git a/t/README b/t/README
>> index 0e4e8d8..aa4ed28 100644
>> --- a/t/README
>> +++ b/t/README
>> @@ -18,25 +18,48 @@ The easiest way to run tests is to say "make".  This runs all
>> ...
>
> This describes the general framework of tests from the point of view of a
> person who runs them and reads their output well.  I'll replace ab/tap
> topic with these five patches.
>
> I'd however like to ask you to update the sections in t/README to help
> test writers.  You have gained enough experience with patches 4 and 5 (and
> with patch 2 for Perl tests) to know what kind of script constructs, used
> by people who are used to the old way of writing our tests, would cause
> the TAP stuff to break, and are in the ideal position to rewrite that
> section.  Two examples of what is drastically different from the old world
> order are "do not print to the standard output strings that begin with XX
> (or partial lines)" and "here is how to skip the remainder of the tests",
> but you may have a handful of more rules.  I expect that "Writing Tests"
> through "Test harness library" sections would be affected.
>
> Earlier I kept wondering if this series is worth the trouble.  Having to
> learn and follow the set of these new rules is exactly what I meant by
> "trouble".  Let's make sure that the new rules are clear, small, and easy
> to follow for other contributors.

I'll write those docs, but I probably won't have time in the next few days so I'll submit a patch for that it separately if that's OK.

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 16 in “TAP support for Git”
  1. 0/5 TAP support for GitÆvar Arnfjörð Bjarmason, Jun 24, 2010
  2. 1/5 test-lib: Adjust output to be valid TAP formatÆvar Arnfjörð Bjarmason, Jun 24, 2010
  3. Jakub NarebskiJun 24, 2010
  4. Ævar Arnfjörð BjarmasonJun 24, 2010
  5. 1/5 test-lib: Adjust output to be valid TAP formatÆvar Arnfjörð Bjarmason, Jun 24, 2010
  6. Junio C HamanoJun 25, 2010
  7. Ævar Arnfjörð BjarmasonJun 25, 2010
  8. Junio C HamanoJun 25, 2010
  9. Ævar Arnfjörð BjarmasonJun 25, 2010
  10. 2/5 test-lib: Make the test_external_* functions TAP-awareÆvar Arnfjörð Bjarmason, Jun 24, 2010
  11. 3/5 test-lib: output a newline before "ok" under a TAP harnessÆvar Arnfjörð Bjarmason, Jun 24, 2010
  12. 4/5 tests: Skip tests in a way that makes sense under TAPÆvar Arnfjörð Bjarmason, Jun 24, 2010
  13. 5/5 tests: Say "pass" rather than "ok" on empty lines for TAPÆvar Arnfjörð Bjarmason, Jun 24, 2010
  14. t9700: Use Test::More->builder, not $Test::Builder::TestÆvar Arnfjörð Bjarmason, Jun 26, 2010
  15. t9700: Use Test::More->builder, not $Test::Builder::TestÆvar Arnfjörð Bjarmason, Jun 26, 2010
  16. Junio C HamanoJun 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.