git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-p4 move/delete errors

From
TBThomas Berg <merlin66b@gmail.com>
Date
Jul 9, 2010, 21:32 UTC
Message-ID
<AANLkTilQtnIzNCcRzYzSqPEvXenHgND-_SAWmUeM64BH@mail.gmail.com>
In-Reply-To
<F94DAB9A-A06D-46ED-9AAA-EDE850365054@gmail.com>
On Fri, Jul 9, 2010 at 11:20 PM, Lance Linder <llinder@gmail.com> wrote:
> Thanks for the tip about keyword expansion. Fortunately for me we don't use those.
We don't either.
> When I was trying to debug this the problem seemed to be that the original file is removed from the local Perforce workspace before the p4 diff command is issued. I am not sure how the server upgrade caused this behavior but it was the only thing that changed when I first started seeing the error.

Hasn't Perforce always deleted files immediately when they are marked for deletion?

Anyway, as far as I can see from the git-p4 source code, the command is only used to generate the diff preview in the interactive window that pops up when you "git p4 submit". So if you replace the line diff = p4_read_pipe("diff -du ...") with diff = ""

it should start working again (the diff preview part will become empty). I'm unable to test it right now, but fairly sure it will work. I'll see if I can find a better solution when I have access to the Perforce server again.

Thomas
Previous: Lance LinderNext: Thomas Berg
Message 6 of 7 in “git-p4 move/delete errors”
  1. Lance LinderMay 28, 2010
  2. Thomas BergJul 9, 2010
  3. Lance LinderJul 9, 2010
  4. Tor Arvid LundJul 9, 2010
  5. Lance LinderJul 9, 2010
  6. Thomas BergJul 9, 2010
  7. Thomas BergJul 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.