git+ssh protocol regression

From: Pascal Obry <pascal@obry.net>
Date: Jun 22, 2010, 09:22 UTC
Message-ID: <AANLkTilFMUJ8mcZaEeqgNF7QhUFVO7kiFUD2M5Vblo7h@mail.gmail.com>

With current git version doing:

   $ git clone git+ssh://server/path
   fatal: I don't handle protocol 'git ssh'

The '+' has been changed to ' '. This looks like the protocol in the URL has been decoded (a + is an encoded space).

The culprit is:

<<
commit 9d2e942070b235e1f4a0b8dd4c55a6b3f0fe914a
Author: Jeff King <peff@peff.net>
Date:   Sun May 23 05:19:44 2010 -0400

    decode file:// and ssh:// URLs

    We generally treat these as equivalent to "/path/to/repo"
    and "host:path_to_repo" respectively. However, they are URLs
    and as such may be percent-encoded. The current code simply
    uses them as-is without any decoding.

    With this patch, we will now percent-decode any file:// or
    ssh:// url (or ssh+git, git+ssh, etc) at the transport
    layer. We continue to treat plain paths and "host:path"
    syntax literally.

    Signed-off-by: Jeff King <peff@peff.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

>>

I've not seen discussion about this regression. I don't think it is intended.

Patch will be sent in a followup message.

Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595