Re: [PATCH 5/6] tree_entry_interesting(): remove dependency on struct diff_options

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sep 28, 2010, 22:00 UTC
Message-ID: <AANLkTikso2O5M_ZBr1pvr8jqg=h7jhd+U+fBGossdU0W@mail.gmail.com>
In-Reply-To: <7vtylavnfx.fsf@alter.siamese.dyndns.org>

On Tue, Sep 28, 2010 at 8:20 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> This function can be potentially used in more places than just
>> tree-diff.c. "struct diff_options" does not make much sense outside
>> diff_tree_sha1().
>
> This does a bit more than that; it does not call tree_entry_extract()
> anymore, and instead uses the knowledge of its underlying implementation.
> The mode of the entry that is passed to S_ISDIR() check is not cleansed
> with canon_mode() anymore.

Hmm.. missed that. Thanks for catching.

-- 
Duy