git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Try to remove the given path even if it can't be opened

From
Alex Riesen <raa.lkml@gmail.com>
Date
Apr 1, 2011, 14:01 UTC
Message-ID
<AANLkTikjfkieO9VdpEka7Hb0Fk3st1+dCMF9ti0Kg5Fw@mail.gmail.com>
In-Reply-To
<4D95D528.6050409@drmicha.warpmail.net>
On Fri, Apr 1, 2011 at 15:37, Michael J Gruber <git@drmicha.warpmail.net> wrote:
Show 7 quoted lines
> How about simply
>
> if (!dir)
>        return rmdir(path->buf);
>
> like we do later on in that function?
>

I'm used to try to keep the returned value of a function I modify, and I'm also used to not trust the return values of the functions I don't control. That's to my defense.

But you're unquestionably right.
Previous: Michael J GruberNext: Junio C Hamano
Message 3 of 6 in “Try to remove the given path even if it can't be opened”
  1. Try to remove the given path even if it can't be openedAlex Riesen, Apr 1, 2011
  2. Michael J GruberApr 1, 2011
  3. Alex RiesenApr 1, 2011
  4. Junio C HamanoApr 1, 2011
  5. Try to remove the given path even if it can't be openedAlex Riesen, Apr 2, 2011
  6. Junio C HamanoApr 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.