Re: [PATCH] smart-http: Don't use Expect: 100-Continue
- From
Shawn Pearce <spearce@spearce.org>
- Date
- Feb 15, 2011, 23:54 UTC
- Message-ID
- <AANLkTikVp0xC3OciJ7eN=P4+5_Pu=KPeO5X_+b_Nv30N@mail.gmail.com>
- In-Reply-To
- <7vr5b9nkzb.fsf@alter.siamese.dyndns.org>
On Tue, Feb 15, 2011 at 11:42, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
>> diff --git a/remote-curl.c b/remote-curl.c
>> index 04d4813..3d82dc2 100644
>> --- a/remote-curl.c
>> +++ b/remote-curl.c
>> @@ -356,14 +356,59 @@ static size_t rpc_in(const void *ptr, size_t eltsize,
>> ...
>> +static int probe_rpc(struct rpc_state *rpc)
>> +{
>> +...
>> + curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
>> + curl_easy_setopt(slot->curl, CURLOPT_FILE, buf);
>> +
>> + err = run_slot(slot);
>> +
>> + curl_slist_free_all(headers);
>> + strbuf_release(&buf);
>> + return err;
>> +}
>
> Hmm, I am getting
>
> remote-curl.c:403: error: call to '_curl_easy_setopt_err_cb_data' declared
> with attribute warning: curl_easy_setopt expects a private data pointer as
> argument for this option
>
> Shouldn't the above be giving a pointer to buf anyway?Yes. Please squash your patch into mine. I'm surprised my build doesn't have sufficient warning flags enabled when I built this. :-(
-- Shawn.