git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] merge-recursive: Workaround unused variable warning

From
Elijah Newren <newren@gmail.com>
Date
Aug 18, 2010, 23:13 UTC
Message-ID
<AANLkTikVWd60Pe3-X2xj4mWhtiTf9VgydYJ7HKxsp+dd@mail.gmail.com>
In-Reply-To
<7vk4nn8soz.fsf@alter.siamese.dyndns.org>
On Wed, Aug 18, 2010 at 4:25 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> I actually was hoping that my weatherbaloon patch will illustrate that a
> new special case these people may make to process_entry() to leave other
> cases unprocessed do _NOT_ have to be handled by process_df_entry().
>
> The "if" statement in process_df_entry() would check if the entry is
> something the function is ready to resolve, and otherwise punts.  A new
> exception they add to process_entry() can introduce a separate phase (just
> like process_df_entry() is not done in parallel with other kinds of
> entries inside the process_entry() but as a separate post-processing
> phase) between the loop that calls process_df_entry() and the loop that
> checks if there is a remaining entry.  And it probably should, as such a
> new exception may not have anything to do with "df", and adding such a
> logic to process_df_entry() would be wrong ;-).

That makes sense and sounds like a good idea to me. I think we should go with your patch, modulo possibly modifying the comment's wording.

Previous: Junio C HamanoNext: Elijah Newren
Message 8 of 9 in “Fix windows portability issues in en/d-f-conflict-fix series”
  1. 0/2 Fix windows portability issues in en/d-f-conflict-fix seriesElijah Newren, Aug 13, 2010
  2. 1/2 merge-recursive: Workaround unused variable warningElijah Newren, Aug 13, 2010
  3. Elijah NewrenAug 18, 2010
  4. Jonathan NiederAug 18, 2010
  5. Junio C HamanoAug 18, 2010
  6. Elijah NewrenAug 18, 2010
  7. Junio C HamanoAug 18, 2010
  8. Elijah NewrenAug 18, 2010
  9. 2/2 Mark tests that use symlinks as needing SYMLINKS prerequisiteElijah Newren, Aug 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.