Re: [PATCH RFC GSoC] gitweb: Use -M option while using format-patch

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: May 10, 2010, 16:56 UTC
Message-ID: <AANLkTikR7zxbhcAjg2WXv9V-eFOkPMf77uCpmo8csr7n@mail.gmail.com>
In-Reply-To: <201005101841.40011.jnareb@gmail.com>

On Mon, May 10, 2010 at 6:41 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 13 quoted lines

> CC-ed Guiseppe Bilotta, author of 'patch' and 'patches' views
> (you can find this information using "git blame" or "git log --grep").
>
> On Mon, 10 May 2010, Pavan Kumar Sunkara wrote:
>
>> Add option '-M' to use with format-patch whcih detects
>> renames in the commit.
>
>  Subject: [PATCH RFC GSoC] gitweb: Use @diff_opts while using format-patch
>
>  Make git-format-patch (used by 'patch' and 'patches' views) use the
>  same rename detection options that git-diff and git-diff-tree (used
>  by 'commitdiff', 'blobdiff', etc.) use.

Excellent idea.

> Note that I am not sure if it is really a good change, as it might
> create patches that (currently) can be applied only with git.

I think we can live with that. If we get strong complains about this, we can always introduce support for extra options to cancel the rename detection. (Also, the upcoming GNU patch release seems to support the git diff format, including copies and renames.)

Show 9 quoted lines

> -- >8 --
> Subject: [PATCH RFC GSoC] gitweb: Use @diff_opts while using format-patch
>
> Make git-format-patch (used by 'patch' and 'patches' views) use the
> same rename detection options that git-diff and git-diff-tree (used
> by 'commitdiff', 'blobdiff', etc.) use.
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
> Acked-by: Jakub Narebski <jnareb@gmail.com>

Acked-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Show 20 quoted lines

> ---
>  gitweb/gitweb.perl |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git i/gitweb/gitweb.perl w/gitweb/gitweb.perl
> index 225f404..d983ce5 100755
> --- i/gitweb/gitweb.perl
> +++ w/gitweb/gitweb.perl
> @@ -6295,8 +6295,8 @@ sub git_commitdiff {
>                        }
>                        push @commit_spec, '--root', $hash;
>                }
> -               open $fd, "-|", git_cmd(), "format-patch", '--encoding=utf8',
> -                       '--stdout', @commit_spec
> +               open $fd, "-|", git_cmd(), "format-patch", @diff_opts,
> +                       '--encoding=utf8', '--stdout', @commit_spec
>                        or die_error(500, "Open git-format-patch failed");
>        } else {
>                die_error(400, "Unknown commitdiff format");
>

-- 
Giuseppe "Oblomov" Bilotta