Re: [PATCH] t/lib-git-svn.sh: use $PERL_PATH for perl, not perl from $PATH

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 11, 2010, 18:45 UTC
Message-ID: <AANLkTikOnWpByxhUNsoOrvzJP83xJfLT6JJQZ4M2XnTN@mail.gmail.com>
In-Reply-To: <7vzkwtxaot.fsf@alter.siamese.dyndns.org>

On Wed, Aug 11, 2010 at 18:32, Junio C Hamano <gitster@pobox.com> wrote:

> Thanks.  Other test scripts (and the insn in t/README) refer to PERL_PATH
> already and t/test-lib.sh includes build options for its definition, so
> this should be complete.

There's actually a lot more (most of these):

    $ ack -l '\bperl.*-\w*e' *sh
    annotate-tests.sh
    diff-lib.sh
    gitweb-lib.sh
    lib-t6000.sh
    t1010-mktree.sh
    t1300-repo-config.sh
    t3300-funny-names.sh
    t4012-diff-binary.sh
    t4014-format-patch.sh
    t4020-diff-external.sh
    t4029-diff-trailing-space.sh
    t4030-diff-textconv.sh
    t4031-diff-rewrite-binary.sh
    t4103-apply-binary.sh
    t4116-apply-reverse.sh
    t4200-rerere.sh
    t5300-pack-object.sh
    t5303-pack-corruption-resilience.sh
    t6011-rev-list-with-bad-commit.sh
    t6013-rev-list-reverse-parents.sh
    t6300-for-each-ref.sh
    t9104-git-svn-follow-parent.sh
    t9119-git-svn-info.sh
    t9129-git-svn-i18n-commitencoding.sh
    t9137-git-svn-dcommit-clobber-series.sh
    t9143-git-svn-gc.sh
    test-lib.sh

But they're all using standard features of perl for one-liners. It's a reasonable assumption that we can use the perl in $PATH in those cases. But maybe we should change those too.