Re: [PATCH v2] Documentation/git-clone: describe --mirror more verbose

From: Darren Hart <darren@dvhart.com>
Date: Oct 4, 2010, 14:42 UTC
Message-ID: <AANLkTikFzbWJ9CZ5skXe38+QF3QRWK5hfTWJhc5FOYK_@mail.gmail.com>
In-Reply-To: <1286185878-23795-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi Uwe,

(sorry for the dup Uwe)

Thanks for iterating on this with Michael. The following looks good to me, with one exception below:

2010/10/4 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:

Show 22 quoted lines

> Some people in #linux-rt claimed that you cannot define "--mirror" with
> "mirror" only.
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Darren 'Some People' Hart <darren@dvhart.com>
> Cc: Michael J Gruber <git@drmicha.warpmail.net>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  Documentation/git-clone.txt |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
> index dc7d3d1..524a080 100644
> --- a/Documentation/git-clone.txt
> +++ b/Documentation/git-clone.txt
> @@ -128,7 +128,12 @@ objects from the source repository into a pack in the cloned repository.
>        configuration variables are created.
>
>  --mirror::
> -       Set up a mirror of the remote repository.  This implies `--bare`.
> +       Set up a mirror of the source repository.  This implies `--bare`.
> +       Compared to `--bare`, `--mirror` does not only map local branches of

s/does not only map/not only maps/

> +       the source to local branches of the target but all refs (including

s/but all refs/, it maps all refs/

These changes form a more parallel sentence structure and is easier to read/parse IMO.

Thanks,

Darren Hart

Show 10 quoted lines

> +       remote branches, notes etc.) and sets up a refspec configuration such
> +       that all these refs are overwritten by a `git remote update` in the
> +       target repository.
>
>  --origin <name>::
>  -o <name>::
> --
> 1.7.2.3
>
>

-- Darren Hart