git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH next] test-lib: set $DIFF to diff if it is unset

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 10, 2010, 09:46 UTC
Message-ID
<AANLkTikCQ_up4UY445RE-wU_jeP9g63sPlix0wm6KJNo@mail.gmail.com>
In-Reply-To
<06ffbe0ca6aac061336f6f595e89f75c09ab88ac.1276162629.git.trast@student.ethz.ch>
On Thu, Jun 10, 2010 at 09:39, Thomas Rast <trast@student.ethz.ch> wrote:
Show 13 quoted lines
> Since 7b3bdbb (fixup: do not unconditionally disable "diff -u",
> 2010-05-31), test-lib.sh depends on having $DIFF set in the
> environment for the construction of $GIT_TEST_CMP.  While this works
> when called from the main Makefile, it fails if the tests are called
> on their own and the user does not have $DIFF set.
>
> Set it to 'diff' if it is unset, like the Makefile does.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> I have an uneasy feeling that I must be missing something, seeing as
> this went unnoticed for 10 days...
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

I spotted it too when preparing the TAP series, I just didn't submit a fix for it.

Previous: Thomas RastNext: Brandon Casey
Message 2 of 7 in “test-lib: set $DIFF to diff if it is unset”
  1. test-lib: set $DIFF to diff if it is unsetThomas Rast, Jun 10, 2010
  2. Ævar Arnfjörð BjarmasonJun 10, 2010
  3. Brandon CaseyJun 10, 2010
  4. Junio C HamanoJun 11, 2010
  5. Brandon CaseyJun 11, 2010
  6. Brandon CaseyJun 15, 2010
  7. Thomas RastJun 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.