git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/8] git-p4: add missing newline in initial import message

From
Tor Arvid Lund <torarvid@gmail.com>
Date
Feb 8, 2011, 08:48 UTC
Message-ID
<AANLkTikAqDNwGbFfZ=kNyJ4rxdTmesaOmtPYmM3bLf_6@mail.gmail.com>
In-Reply-To
<20110205225155.GD30963@arf.padd.com>
On Sat, Feb 5, 2011 at 11:51 PM, Pete Wyckoff <pw@padd.com> wrote:
> The commit message looks wrong without the newline.
>
> Signed-off-by: Pete Wyckoff <pw@padd.com>
Acked-By: Tor Arvid Lund <torarvid@gmail.com>
Show 25 quoted lines
> ---
>  contrib/fast-import/git-p4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index 2fefea4..d2ba215 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1429,7 +1429,7 @@ class P4Sync(Command):
>         print "Doing initial import of %s from revision %s into %s" % (' '.join(self.depotPaths), revision, self.branch)
>
>         details = { "user" : "git perforce import user", "time" : int(time.time()) }
> -        details["desc"] = ("Initial import of %s from the state at revision %s"
> +        details["desc"] = ("Initial import of %s from the state at revision %s\n"
>                            % (' '.join(self.depotPaths), revision))
>         details["change"] = revision
>         newestRevision = 0
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Previous: Pete WyckoffNext: Pete Wyckoff
Message 8 of 18 in “git-p4 fixes and enhancements”
  1. 0/8 git-p4 fixes and enhancementsPete Wyckoff, Feb 5, 2011
  2. 1/8 git-p4: test scriptPete Wyckoff, Feb 5, 2011
  3. Vitor AntunesFeb 6, 2011
  4. Junio C HamanoFeb 7, 2011
  5. Pete WyckoffFeb 7, 2011
  6. 2/8 git-p4: fix key error for p4 problemPete Wyckoff, Feb 5, 2011
  7. 3/8 git-p4: add missing newline in initial import messagePete Wyckoff, Feb 5, 2011
  8. Tor Arvid LundFeb 8, 2011
  9. 4/8 git-p4: accommodate new move/delete type in p4Pete Wyckoff, Feb 5, 2011
  10. Tor Arvid LundFeb 8, 2011
  11. 5/8 git-p4: reinterpret confusing p4 messagePete Wyckoff, Feb 5, 2011
  12. 6/8 git-p4: better message for "git-p4 sync" when not clonedPete Wyckoff, Feb 5, 2011
  13. Tor Arvid LundFeb 8, 2011
  14. 7/8 git-p4: decode p4 wildcard charactersPete Wyckoff, Feb 5, 2011
  15. Tor Arvid LundFeb 8, 2011
  16. Pete WyckoffFeb 8, 2011
  17. 8/8 git-p4: support clone --barePete Wyckoff, Feb 5, 2011
  18. Tor Arvid LundFeb 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.