Re: [RFC/PATCH 2/4] revert: refactor code into a do_pick_commit() function

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 30, 2010, 11:19 UTC
Message-ID: <AANLkTik6SBEkOICHdMYprzGitfS2hezDXKQ8Q5R8cAYs@mail.gmail.com>
In-Reply-To: <20100529044044.569.69037.chriscool@tuxfamily.org>

Hi Christian,

Excellent feature to work on- I've wanted to cherry pick a range several times.

Christian Couder wrote:

Show 5 quoted lines

> -static int revert_or_cherry_pick(int argc, const char **argv)
> +static int do_pick_commit()
>  {
>        unsigned char head[20];
>        struct commit *base, *next, *parent;

Is there a better way to do this instead of allocating memory for each commit? When you cherry pick a lot of commits, it might make sense to use a shared memory pool.

> +       /* this is copied from the shell script, but it's never triggered... */
> +       if (action == REVERT && !no_replay)
> +               die("revert is incompatible with replay");

If it's here for historical reasons, why don't you remove it now?

-- Ram