git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/t9700/test.pl: don't access private object members, use public access methods

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 29, 2010, 02:19 UTC
Message-ID
<AANLkTik3L7VcjezVK_8PCKsSpNFaTfYNvsOAgckhv-6K@mail.gmail.com>
In-Reply-To
<OYRSzEHOHSti8exa5KJzWIUEyJ8xb2sfcvm4pUcvYhBXldZMw8JzP6a6cRcRRIZjiOtW9kzmnVA@cipher.nrlssc.navy.mil>
On Mon, Jun 28, 2010 at 22:51, Brandon Casey <casey@nrlssc.navy.mil> wrote:
Show 10 quoted lines
> From: Brandon Casey <drafnel@gmail.com>
>
> This test is accessing private object members of the Test::More and
> Test::Builder objects.  Older versions of Test::More did not implement
> these variables using a hash.
>
> My system complains as follows:
>
>   Can't coerce array into hash at <snip>/t/t9700/test.pl line 13.
>   BEGIN failed--compilation aborted at <snip>/t/t9700/test.pl line 15.
Just for the record, what version of Test::More is that:
    perl -MTest::More -le 'print $Test::More::VERSION'
> There are public access methods available for retrieving and setting these
> variables, so let's use them instead.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
This looks good, sorry for the API mistake on my part.
Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Previous: Brandon CaseyNext: Brandon Casey
Message 2 of 4 in “t/t9700/test.pl: don't access private object members, use public access methods”
  1. t/t9700/test.pl: don't access private object members, use public access methodsBrandon Casey, Jun 28, 2010
  2. Ævar Arnfjörð BjarmasonJun 29, 2010
  3. Brandon CaseyJun 29, 2010
  4. Junio C HamanoJun 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.