Re: [PATCH] doc: technical details about the index file format
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Sep 2, 2010, 08:56 UTC
- Message-ID
- <AANLkTi=wESk38u1XSTL1rd2__eQzHfSuq-EbqooxmcVw@mail.gmail.com>
- In-Reply-To
- <1283351989-19426-1-git-send-email-pclouds@gmail.com>
2010/9/1 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
Show 11 quoted lines
> +== Index entry > + > + Index entries are sorted in ascending order on the name field, > + interpreted as a string of unsigned bytes. Entries with the same > + name are sorted by their stage field. > + > + 32-bit ctime seconds, the last time a file's metadata changed > + this is stat(2) data > + > + 32-bit ctime nanoseconds (modulo 1G) > + this is stat(2) data
Maybe I'm missing something, but I failed to find where "modulo 1G" comes from. AFAICS (read-cache.c), the stat data are saved almost unmodified (casted to unsigned int). (BTW, is 1G the Gravitational Constant or what?)
I'm not sure it is safe to assume that every system Git will be ported to defines "unsigned int" to be 32 bits. OTOH, never met one where it is something else. Still, using uint32_t (the POSIX types) in ondisk_cache_entry would be clearer (unlikely alignment issues aside.