Re: What's cooking in git.git (Sep 2010, #01; Wed, 1)

From: Elijah Newren <newren@gmail.com>
Date: Sep 1, 2010, 20:54 UTC
Message-ID: <AANLkTi=ma8MLssD_1YeSju7iJucRN9NFzYESJ2rGhyjv@mail.gmail.com>
In-Reply-To: <7vaao15jk2.fsf@alter.siamese.dyndns.org>

Show 5 quoted lines

> * en/object-list-with-pathspec (2010-08-26) 2 commits
>  - Make rev-list --objects work together with pathspecs
>  - Add testcases showing how pathspecs are ignored with rev-list --objects
>
> Heard that this is still broken?

Are you possibly remembering v1 of the series, which mis-used the tree_entry_interesting() API, and was fixed by v2 including extra testcases? You merged the latter into pu, so there's no remaining issue I know of.

However, if I've missed some email or other report about any other breakage, let me know and I'll take a look.

Show 8 quoted lines

> * en/tree-walk-optim (2010-08-26) 4 commits
>  - diff_tree(): Skip skip_uninteresting() when all remaining paths interesting
>  - tree_entry_interesting(): Make return value more specific
>  - tree-walk: Correct bitrotted comment about tree_entry()
>  - Document pre-condition for tree_entry_interesting
>
> I think the idea is sound.  For a patch that touches fairly core part of
> the system, it came a bit late in the cycle, though.

I agree, both this and the en/object-list-with-pathspec series probably make sense to wait for 1.7.4.