Re: [PATCH] vcs-svn: Fix some printf format compiler warnings
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Sep 11, 2010, 20:42 UTC
- Message-ID
- <AANLkTi=hhM64Jiph4ERzujyHgEo5C0vjc1oPhdpyxyUD@mail.gmail.com>
- In-Reply-To
- <4C891836.6070608@ramsay1.demon.co.uk>
Ramsay Jones wrote:
> In order to suppress the warnings we use the C99 format specifier > macros PRIo32 and PRIu32 from <inttypes.h>.
Thanks.
> The addition to git-compat-util.h is required in order to not break > the build on both MinGW and MSVC
Yep, looks sane. So for what it's worth:
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
I see that David has already applied this to the svn-da tree, but it would be good to have the fix in git, too.