Re: [RFC/PATCH 3/3] builtin/show.c: do not prune by pathspec
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Mar 31, 2011, 13:35 UTC
- Message-ID
- <AANLkTi=S9WUWHE8DZvQ2sxMLAJigi1wm3iU_PL5h4Mzd@mail.gmail.com>
- In-Reply-To
- <4D948105.3050009@drmicha.warpmail.net>
On Thu, Mar 31, 2011 at 8:26 PM, Michael J Gruber <git@drmicha.warpmail.net> wrote:
Show 5 quoted lines
>> Tests please? > > Heck, we don't have any to begin with, and this is marked RFC. Given our > usual reluctance to change even undocumented behavior I'm not going to > bother with tests for an RFC.
Ugh.. I missed the "RFC" part on the subject. Sorry.
Show 11 quoted lines
>>> As an intended side effect, users mistaking "git show commit -- path" >>> for "git show commit:path" are automatically reminded that they asked >>> git to show a commit, not a blob. >> >> Nor a tree. I don't really see how "git show commit:path" and "git how >> commit -- path" are relevant for it to be mentioned here. > > "git show commit:path" is relevant because that is what the OP was > trying to do, and "git show commit:path" is relevant because that is > what the OP tried and confused him because there was no output at all. > Not to mention that this is the command this patch is about.
Thanks. I see I also missed the original thread somewhere. Someone needs a sleep, me thinks :)
-- Duy