Re: How you can translate things now, and a plan for the i18n series going forward
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 16, 2011, 23:57 UTC
- Message-ID
- <AANLkTi=E0LYWp7ag8SD8LNCKkKopGczJL0QnuOiH2UEu@mail.gmail.com>
- In-Reply-To
- <7vipwpxbam.fsf@alter.siamese.dyndns.org>
On Sat, Feb 12, 2011 at 21:12, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>> *** TODO Introduce a skeleton no-op gettext, just the
>> infrastructure minus the interesting stuff
>>
>> I.e. just add:
>>
>> #define N_(s) (s)
>> #define _(s) (s)
>>
>> *** TODO Add no-op C gettextize patches
>>
>> This will change "foo" to _("foo") everywhere, but will be a no-op
>> due to it being macroed out.
>
> It would be best to get this as early as possible while not many topics
> are in 'next'; it is preferrable if we can rebase other topics in 'pu' on
> top of the result of this step.Here's a work-in-progress version of this: https://github.com/avar/git/compare/master...ab/i18n-c-_-only
I still have to:
* Add NO_GETTEXT_POISON to more tests, some things have broken due to new strings / changed tests.
* Squash the !fixup patches in appropriately.
But otherwise does this seem good? I.e. having just those stub macros, a lot of *.c patches, including gettext.h in cache.h.
And having NO_GETTEXT_POISON be part of the actual patches, of course I'd also have to add something to the test suite to always set that for now.