Re: [PATCH 01/10] add: do not rely on dtype being NULL behavior

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Nov 17, 2010, 06:38 UTC
Message-ID: <AANLkTi=DUXS8i9oE+2spm3_g=F137AOfKi0rj3Tu=+AG@mail.gmail.com>
In-Reply-To: <7v39r1hz92.fsf@alter.siamese.dyndns.org>

On Wed, Nov 17, 2010 at 1:58 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> Hmm.. get_index_dtype() would return DT_DIR if the submodule exists in
>> index. If it does not it must be a directory in worktree, right?
>> Call flow: excluded_from_list() -> get_dtype() -> get_index_dtype()
>
> By the way, your c84de70 (excluded_1(): support exclude files in index,
> 2009-08-20) looks broken.  What happens when the exclude pattern wants a
> directory but specifies it with a wildcard?

It fails. I realized that just this week unfortunately. That commit is reverted in this series.

Show 5 quoted lines

> The safest and sanest first step is to just change DT_UNKNOWN (which
> clearly is a wrong thing to pass) to NULL to keep the current behaviour,
> but it probably makes more sense to do the second step at the same time to
> pass a pointer to an int that holds DT_UNKNOWN to avoid triggering that
> broken codepath.

Yes.

-- 
Duy