git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git merge auto-commit doesn't fire pre-commit hook

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 17, 2011, 04:48 UTC
Message-ID
<AANLkTi=DF6HiMcKA5r_HMTD3roneGZdfqFKZ_sYCy1wG@mail.gmail.com>
In-Reply-To
<6F190320-19AF-4F4A-9AE9-0DDA0839C5FD@adscale.co.nz>

On Wed, Feb 16, 2011 at 11:44 PM, Liam Clarke <liam.clarke-hutchinson@adscale.co.nz> wrote:

Show 6 quoted lines
> Cheers Jay.
>
>> The bypassing of pre-commit hook was and remains to be a conscious design
> decision.
>
> That doesn't sound good for my purposes. It also renders Git merge behaviour significantly surprising. :(

I agree. Note that the grandparent statement belongs to Junio, but he also indicated at the end of the message that he didn't care too deeply.

Personally, I think the commit hooks should fire whenever a commit is made, regardless of the source. Maybe the hooks should move to the low-level commit_tree, or maybe merge should invoke commit instead of commit_tree.

j.
Previous: Liam ClarkeNext: Jay Soffian
Message 4 of 6 in “git merge auto-commit doesn't fire pre-commit hook”
  1. Liam ClarkeFeb 16, 2011
  2. Jay SoffianFeb 17, 2011
  3. Liam ClarkeFeb 17, 2011
  4. Jay SoffianFeb 17, 2011
  5. Jay SoffianFeb 17, 2011
  6. Liam ClarkeFeb 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.