Re: [PATCH 2/2] git-p4: Add copy detection support

From: Vitor Antunes <vitor.hda@gmail.com>
Date: Feb 6, 2011, 17:25 UTC
Message-ID: <AANLkTi=Awi6d77QcbbZ2rDTv6LpP+qjsReJ5=4NyhUBz@mail.gmail.com>
In-Reply-To: <20110206002547.GB31245@arf.padd.com>

Hi Pete,

On Sun, Feb 6, 2011 at 12:25 AM, Pete Wyckoff <pw@padd.com> wrote:

> You can use integrate -t to force the filetype even if the file
> already existed, and skip the whole execbit change.

(Copying help text:
	The -t flag makes the source file's filetype propagate to the target
	file.  Normally, the target file retains its previous filetype.
	Newly branched files always use the source file's filetype.  The
	filetype can still be changed before 'p4 submit' with 'p4 reopen'.
)

Since in git we're only considering newly branched files, I think in this case "-t" will not add anything. In fact, what is being done here is detecting exec bit changes from source to target files - we're not trying to force P4 to use the source's exec bit. Do you agree?

Kind regards,

-- 
Vitor Antunes