Re: tig show <commit> not working anymore?

From: Jonas Fonseca <fonseca@diku.dk>
Date: Sep 21, 2010, 12:56 UTC
Message-ID: <AANLkTi=AUiLJJp6JLqWoJufBFDUKa7u3Eg9Az5uGteqM@mail.gmail.com>
In-Reply-To: <20100920042522.GA21880@bluemoon.alumni.iitm.ac.in>

On Mon, Sep 20, 2010 at 00:25, Kumar Appaiah <a.kumar@alumni.iitm.ac.in> wrote:

Show 15 quoted lines

> On Sun, Sep 19, 2010 at 02:46:22PM -0400, Jonas Fonseca wrote:
>> You fix is not that far off but to fix the second issue I had to do
>> change the function responsible for expanding %(commit). Anyway,
>> should be fixed in 0.16.1.
>
> Unfortunately, this has introduced another (albeit minor) bug: it
> breaks the tree view in some cases. For example:
>
> git clone git://gitorious.org/taggrepper/taggrepper.git
>
> and run tig there, and press `t'. It always gives me a blank tree.
>
> The cause for this is that view->parent is null when the tree view
> is invoked, but you merely pass !view->parent in the call to
> format_argv in prepare_io.

Oops, I should really finish the tig.c split up branch and introduce a test suite to catch stuff like this.

Show 5 quoted lines

> A simple patch to fix this is attached below, but you might have other
> ideas or I might have missed something, or not added sufficient checks
> for the argv vector.
>
> As always, if I have missed something above, please do let me know.

Thanks for the patch and for reporting this. I've fixed this by using view->prev instead of view->parent. The view->prev tracks the list of views whereas view->parent tracks parents/child relationships in split view mode. It was one of the things I refactored not long ago.

-- 
Jonas Fonseca