Re: [PATCH v2] git-rebase--interactive.sh: replace cut with ${v%% *}

From: Chris Johnsen <chris_johnsen@pobox.com>
Date: Sep 18, 2010, 05:25 UTC
Message-ID: <AANLkTi=9rDR0chmPrjK3eAKgg_ECbAjcUYhvP_GELdvc@mail.gmail.com>
In-Reply-To: <7v8w302fu1.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Chris Johnsen <chris_johnsen@pobox.com> writes:
>> It seems like the other uses of cut in git-rebase--interactive.sh
>> would be more awkward if they were replaced with equivalent
>> processing done in-shell with parameter expansions...
>
> More importantly, they are fed output from rev-list and do not have
> breakage you observed on your Mac OS box, do they?
>
> IOW, I don't see anything that needs fixing in other uses.

Right, the other uses of cut do not cause any problems on my system.

Any remaining reason to change them would be along the lines of your "the less of 'cut' we see, the better" and the possible efficency of in-shell processing (e.g. for msys/cygwin).

-- 
Chris