Re: [PATCH] Add case insensitive support in matching pathspec
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Feb 5, 2011, 04:14 UTC
- Message-ID
- <AANLkTi=5j1kjAjY6ek6YXTs24DO9J7X0QQjTB4qrZ_g3@mail.gmail.com>
- In-Reply-To
- <7vei7nxuw5.fsf@alter.siamese.dyndns.org>
On Sat, Feb 5, 2011 at 6:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes: > >>> core.ignorecase should be honored only when files on the filesystem are >>> matched, IMO. >> >> Names in index, just as same as match_pathspec(). > > If the matched entities are names in the index, they should already be > canonical and we shouldn't be matching with icase, no?
The patterns are case-insensitive. The example given in 21444f is "git ls-files mydir" should also match MyDir/* in index. Although by modifying match_one(), it affects more than just git-ls-files. I'm not the original author, so Joshua, was that patch to fix git-ls-files only?
-- Duy