Re: [PATCH 3/3 (alternate)] gitweb: Mark "atnight" author/committer times also for 'localtime'
- From
Kevin Cernekee <cernekee@gmail.com>
- Date
- Mar 18, 2011, 19:07 UTC
- Message-ID
- <AANLkTi=4wyph4fp7sbtw01+eb7FV=WVN4+dGcYiov35v@mail.gmail.com>
- In-Reply-To
- <201103181846.04979.jnareb@gmail.com>
On Fri, Mar 18, 2011 at 10:46 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> Kevin, how about something like this instead? This preserves _intent_ > for why there is local time beside GMT time when 'localtime' is disabled > better, I think.
Fine with me. I had to dig around for a while before I could find an "atnight" commit, so I don't think this is something that is likely to occur often in my environment. But I can see how it would be useful to preserve the existing functionality.
I applied your patch and verified it in both localtime=0 and localtime=1 cases. So:
Tested-by: Kevin Cernekee <cernekee@gmail.com>
> Junio and Kevin, I am not sure if authorship should remain with Kevin, > or should it revert to me; the solution is quite different.
I would suggest reverting it to you.
Show 9 quoted lines
> @@ -4003,15 +4003,23 @@ sub git_print_authorship_rows {
> my %wd = parse_date($co->{"${who}_epoch"}, $co->{"${who}_tz"});
> print "<tr><td>$who</td><td>" .
> format_search_author($co->{"${who}_name"}, $who,
> - esc_html($co->{"${who}_name"})) . " " .
> + esc_html($co->{"${who}_name"})) . " " .
> format_search_author($co->{"${who}_email"}, $who,
> - esc_html("<" . $co->{"${who}_email"} . ">")) .
> + esc_html("<" . $co->{"${who}_email"} . ">")) .FWIW, this does create a few >80 character lines. But CodingGuidelines doesn't say whether that limit applies to Perl scripts or just C.