git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [1.8.0] Support quoting in .gitattributes, .gitignore

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Feb 4, 2011, 13:17 UTC
Message-ID
<AANLkTi=0wrCVLetPsDGQAMYupfULFi6k2JijDnJQXPbO@mail.gmail.com>
In-Reply-To
<7vbp2t0wld.fsf@alter.siamese.dyndns.org>
On Fri, Feb 4, 2011 at 2:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> Migration plan:
>>
>> I think a release note mentioning this is enough. No migration needed.
>>
>> But to be safe, we can make post-1.7.5 warn users about patterns with
>> leading double quote. By 1.8.0, the new behavior will be used.
>
> That's obviously not a migration plan, and it is worse than not having the
> warning at all.  People with paths that begin with dq (which I suspect
> would be an empty set) will get wraning every time they do anything with
> git, and until 1.8.0 there is no way to turn that warnings off without
> breaking their pattern (like removing the entry from the attributes file),
> and when 1.8.0 comes their patterns will break.

Actually they can turn "<dq>abc" pattern to "[<dq>]abc". The tip should be included in the warning. The warning would then be gone and their patterns are 1.8.0-safe.

Show 11 quoted lines
> How about introducing a new feature in .gitattributes file so that the
> parser can tell if the file is (1) written pre-1.7.5 that depends on the
> old behaviour, (2) written post-1.7.5 by a person who is aware of the dq
> convention, but still relying on the old behaviour, (3) written post-1.7.5
> to take advantage of the new behaviour?  E.g., you can explicitly mark
> your .gitattributes file by putting "# feature: no-cq-pattern" as the
> first line that the patterns in the file relies on the traditional
> behaviour, or "# feature: cq-pattern" to cause the parser to interpret
> cquoted patterns, and the last 1.7.x will warn if a file does not have
> this explicit marking, but has a pattern that would change the behaviour.
> Then 1.8.0 would flip the default.

Nice. Chances of having a pattern with leading dq are small enough that I'd rarely need to add "#feature: cq-pattern" in new .gitattributes (i.e it does not bother the majority of users).

So the syntax of this line would be:
# feature: <feature>[,<feature>]*

where features in lowercase are mandatory, Git will abort if it does not understand such a feature. Features start with an uppercase letter is optional. Hmm?

-- 
Duy
Previous: Junio C Hamano
Message 3 of 3 in “[1.8.0] Support quoting in .gitattributes, .gitignore”
  1. Nguyen Thai Ngoc DuyFeb 3, 2011
  2. Junio C HamanoFeb 3, 2011
  3. Nguyen Thai Ngoc DuyFeb 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.