Re: RFC: Adding an option to log-like commands to call an external command for each revision

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 12, 2010, 22:44 UTC
Message-ID: <AANLkTi=0S=fAosE6Ejp=cJiMuMsi6o-cS023tQTL5MC1@mail.gmail.com>
In-Reply-To: <7vmxrmd57r.fsf@alter.siamese.dyndns.org>

On Sun, Sep 12, 2010 at 21:25, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> I just like the UI of having each commit "pop up" where I can either
>> page up/down within the commit, or dismiss it with "q" and go to the
>> next one.
>>
>> You can't do both of those in a pager, up/down goes across commits,
>> and "q" quits the whole pager.
>
> I would throw this not into the incomplete scriptability category but into
> the "user does not know how to use his pager" category.  With "/^commit .*"
> you can not only advance to the next commit with "/<RET>", you can go back
> to the previous one with "?<RET>", and keep going in the same direction
> with "n".

That was already suggested, but I prefer not to see anything else in the pager myself. E.g. if I have a large terminal window I want to see *only* the pertinent commit in that entire window, nothing else.

Which is why I still use my git-review alias.

> wouldn't be much of an improvement over "git rev-list | xargs -n1 'cmd'"
> pipeline from the _scriptability_ point of view.
>
> So no.

Fine, I don't think it should be in core either after this discussion. So we're in agreement.

The problem I was trying to solve was solved with Jeff's suggestion.