Re: [PATCH 13/14] t4135-*.sh: Skip the "backslash" tests on cygwin

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Dec 22, 2010, 01:44 UTC
Message-ID: <AANLkTi=-7ihdW_cMiAqnyjbUE_d35OFrSSnQQw4mi64G@mail.gmail.com>
In-Reply-To: <4D1100A3.2010309@ramsay1.demon.co.uk>

On Wed, Dec 22, 2010 at 2:31 AM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

> The problem boils down to the call to strncmp_icase() suppressing the call to
> fnmatch() when the pattern contains glob chars, but the (remaining) string is
> equal to the name; thus returning an exact match (MATCHED_EXACTLY) rather than
> calling fnmatch (and returning either no-match or MATCHED_FNMATCH).

I think that's expected behavior. Wildcard pathspecs are fixed pathspecs will additional wildcard matching support and can match both ways. See 186d604 (glossary: define pathspec)

> [BTW, I started looking at the history of this function and I think this
> problem has been there for a long time!]

Not only in this function. pathspec_matches() in builtin/grep.c behaves the same (I think).

> Hmm, I think this is all being rewritten, at the moment (in branch
> nd/struct-pathspec) isn't it?

Yes. Thanks for pulling me in. I didn't know recent match_one() has case-insensitive support.

-- 
Duy