Re: [PATCH v2 1/4] tests: Infrastructure for Git smoke testing

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Aug 8, 2010, 20:20 UTC
Message-ID: <AANLkTi=+i0a0Sj542=tzKqeGe0CBYA1F=-njc_yObwa8@mail.gmail.com>
In-Reply-To: <1281278967-31376-2-git-send-email-avarab@gmail.com>

Heya,

On Sun, Aug 8, 2010 at 09:49, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 10 quoted lines

> +smoke_report: smoke
> +       curl \
> +               -H "Expect: " \
> +               -F project=Git \
> +               -F architecture="$(uname_M)" \
> +               -F platform="$(uname_S)" \
> +               -F revision="$(GIT_VERSION)" \
> +               -F report_file=@test-results/git-smoke.tar.gz \
> +               $(SMOKE_UPLOAD_FLAGS) \
> +               http://smoke.git.nix.is/app/projects/process_add_report/1 \

I think at the very least this URL should be given it's own variable so that it can be overridden easily.

-- 
Cheers,

Sverre Rabbelier