Re: [PATCH v1] Configure Git contribution guidelines for github.com
Show 27 quoted lines
> On 10 Jun 2017, at 14:48, Philip Oakley <philipoakley@iee.org> wrote:
>
> From: "Lars Schneider" <larsxschneider@gmail.com>
>> Many open source projects use github.com for their contribution process.
>> Although we mirror the Git core repository to github.com [1] we do not
>> use any other github.com service. This is unknown/unexpected to a
>> number of (potential) contributors and consequently they create Pull
>> Requests against our mirror with their contributions. These Pull
>> Requests become stall [2]. This is frustrating to them as they think we
>> ignore them and it is also unsatisfactory for us as we miss potential
>> code improvements and/or new contributors.
>>
>> GitHub offers a way to notify Pull Request contributors about the
>> contribution guidelines for a project [3]. Let's make use of this!
>>
>> [1] https://github.com/git/git
>> [2] https://github.com/git/git/pulls
>> [3] https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
>>
>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>> ---
>
> I see there are currently 84 open PRs (13 in the last 14 days), so it is real.
>
> I also see that the Issues page for git.git appears to be disabled, and will redirect to the pulls page.
>
> Maybe the instructions should also be part of an Issues template which could reduce the potential number of PRs being created (but could create its own problems)
I don't think that is necessary as Issues are disabled for this repo.
>> ...
>> +Thanks for taking the time to contribute to Git! Please be advised, that the Git community does not use github.com for their contributions. Instead, we use a [mailing list](http://public-inbox.org/git/) for code submissions, code reviews, and bug reports.
>
> Isn't the mailing list git@vger.kernel.org, with an archive at http://public-inbox.org/git/ ?
Show 5 quoted lines
>
>> +
>> +Please [read the maintainer notes](http://repo.or.cz/w/git.git?a=blob_plain;f=MaintNotes;hb=todo) to learn how the Git
>
> Is using the repo.or.cz address deliberate as a way of highlighting that Github isn't the centre of the universe when accessing a DVCS repo?
Haha, partly yes. Plus, I wasn't able to figure out quickly how to access the todo blob on GitHub.
> Maybe the kernel.org repo should be first, or at least the alt-git.git repo at repo.or.cz listed in those same notes.
> It's still a good idea though.
Lars Schneider <larsxschneider@gmail.com>